This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Backport meshconfig changes#3631
Merged
jaellio merged 2 commits intoopenservicemesh:release-v0.9from Jun 22, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release-v0.9 #3631 +/- ##
================================================
- Coverage 66.57% 66.44% -0.14%
================================================
Files 169 168 -1
Lines 7904 7912 +8
================================================
- Hits 5262 5257 -5
- Misses 2611 2624 +13
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
@jaellio The backport should preserve the commit history if multiple commits are involved, as in this case. Do not squash these. |
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria
approved these changes
Jun 21, 2021
shashankram
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-picks 55e3b3b and 3f8d154 for v0.9.
Signed-off-by: Jackie Elliott jaellio@microsoft.com
ref(*): move feature flags to meshconfig
Signed-off-by: Jackie Elliott jaellio@microsoft.com
prometheusScraping: Remove prometheus scraping flag
Signed-off-by: Sneha Chhabria snchh@microsoft.com
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?